asdf2014 commented on code in PR #16742:
URL: https://github.com/apache/druid/pull/16742#discussion_r1680611171
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -857,4 +861,44 @@ private SqlNode getSqlNodeFor(SqlInsert insert, int idx)
}
return src;
}
+
+ @Override
+ protected void validateHavingClause(SqlSelect select)
+ {
+ super.validateHavingClause(select);
+ SqlNode having = select.getHaving();
+ if (containsOver(having)) {
+ throw buildCalciteContextException("Window functions are not allowed in
HAVING", having);
+ }
+ }
+
+ private boolean containsOver(SqlNode having)
+ {
+ final Predicate<SqlCall> callPredicate = call -> call.getOperator()
instanceof SqlOverOperator;
+ return containsCall(having, callPredicate);
+ }
+
+ // copy of SqlUtil#containsCall
+ /** Returns whether an AST tree contains a call that matches a given
+ * predicate. */
+ private static boolean containsCall(SqlNode node,
+ Predicate<SqlCall> callPredicate) {
Review Comment:
To fix check style check failures:
```java
Error:
/home/runner/work/druid/druid/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:898:5:
'}' at column 5 should be alone on a line. [RightCurly]
```
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -857,4 +861,44 @@ private SqlNode getSqlNodeFor(SqlInsert insert, int idx)
}
return src;
}
+
+ @Override
+ protected void validateHavingClause(SqlSelect select)
+ {
+ super.validateHavingClause(select);
+ SqlNode having = select.getHaving();
+ if (containsOver(having)) {
+ throw buildCalciteContextException("Window functions are not allowed in
HAVING", having);
+ }
+ }
+
+ private boolean containsOver(SqlNode having)
+ {
+ final Predicate<SqlCall> callPredicate = call -> call.getOperator()
instanceof SqlOverOperator;
+ return containsCall(having, callPredicate);
+ }
+
+ // copy of SqlUtil#containsCall
+ /** Returns whether an AST tree contains a call that matches a given
+ * predicate. */
+ private static boolean containsCall(SqlNode node,
+ Predicate<SqlCall> callPredicate) {
+ try {
+ SqlVisitor<Void> visitor =
+ new SqlBasicVisitor<Void>() {
+ @Override public Void visit(SqlCall call) {
Review Comment:
To fix check style check failures:
```java
Error:
/home/runner/work/druid/druid/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:889:55:
'{' at column 55 should be on a new line. [LeftCurly]
```
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -857,4 +861,44 @@ private SqlNode getSqlNodeFor(SqlInsert insert, int idx)
}
return src;
}
+
+ @Override
+ protected void validateHavingClause(SqlSelect select)
+ {
+ super.validateHavingClause(select);
+ SqlNode having = select.getHaving();
+ if (containsOver(having)) {
+ throw buildCalciteContextException("Window functions are not allowed in
HAVING", having);
+ }
+ }
+
+ private boolean containsOver(SqlNode having)
+ {
+ final Predicate<SqlCall> callPredicate = call -> call.getOperator()
instanceof SqlOverOperator;
+ return containsCall(having, callPredicate);
+ }
+
+ // copy of SqlUtil#containsCall
+ /** Returns whether an AST tree contains a call that matches a given
+ * predicate. */
+ private static boolean containsCall(SqlNode node,
+ Predicate<SqlCall> callPredicate) {
+ try {
+ SqlVisitor<Void> visitor =
+ new SqlBasicVisitor<Void>() {
+ @Override public Void visit(SqlCall call) {
+ if (callPredicate.test(call)) {
+ throw new Util.FoundOne(call);
+ }
+ return super.visit(call);
+ }
+ };
+ node.accept(visitor);
+ return false;
+ } catch (Util.FoundOne e) {
Review Comment:
To fix check style check failures:
```java
Error:
/home/runner/work/druid/druid/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:898:5:
'}' at column 5 should be alone on a line. [RightCurly]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
