kgyrtkirk commented on code in PR #16742:
URL: https://github.com/apache/druid/pull/16742#discussion_r1688096724
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -857,4 +861,50 @@ private SqlNode getSqlNodeFor(SqlInsert insert, int idx)
}
return src;
}
+
+ @Override
+ protected void validateHavingClause(SqlSelect select)
+ {
+ super.validateHavingClause(select);
+ SqlNode having = select.getHaving();
+ if (containsOver(having)) {
+ throw buildCalciteContextException("Window functions are not allowed in
HAVING", having);
+ }
+ }
+
+ private boolean containsOver(SqlNode having)
+ {
+ if (having == null) {
+ return false;
+ }
+ final Predicate<SqlCall> callPredicate = call -> call.getOperator()
instanceof SqlOverOperator;
+ return containsCall(having, callPredicate);
+ }
+
+ // copy of SqlUtil#containsCall
+ /** Returns whether an AST tree contains a call that matches a given
+ * predicate. */
+ private static boolean containsCall(SqlNode node,
+ Predicate<SqlCall> callPredicate)
+ {
+ try {
+ SqlVisitor<Void> visitor =
Review Comment:
I'm not sure if that would be beneficial as this is just a copy of
`SqlUtil#containsCall` until we upgrade to a version which has the fix - after
that it should be removed
at the time of the upgrade
`CalciteSelectQueryTest#testRejectHavingWithWindowExpression` will fail and
suggests to remove these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
