clintropolis commented on code in PR #16748:
URL: https://github.com/apache/druid/pull/16748#discussion_r1683363423
##########
processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java:
##########
@@ -668,11 +688,16 @@ protected void compute()
}
}
catch (Throwable t) {
- closeAllCursors(pQueue);
cancellationGizmo.cancel(t);
- outputQueue.offer(ResultBatch.TERMINAL);
+ cleanup();
}
}
+
+ private void cleanup()
+ {
+ closeAllCursors(pQueue);
+ outputQueue.offer(ResultBatch.TERMINAL);
Review Comment:
oops, i meant to modify this to do a non-blocking offer
clearing the entire queue seems unnecessary since everything has been
modified to check for cancellation, but also don't think this cleanup should be
blocking, so it should only put the terminal marker in there if it can without
blocking (which is what the other action does in its cleanup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
