clintropolis commented on code in PR #16748:
URL: https://github.com/apache/druid/pull/16748#discussion_r1687208144
##########
processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java:
##########
@@ -828,6 +858,11 @@ public void offer(E item)
throw new RuntimeException("Failed to offer result to output queue",
e);
}
}
+
+ public void tryOffer(E item)
Review Comment:
pushed up a change that turns `tryOffer` into `tryOfferTerminal` and added
some comments to clarify the reason for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
