Akshat-Jain commented on PR #16781: URL: https://github.com/apache/druid/pull/16781#issuecomment-2244690514
> I don't fully understand from the above description how it supposed to happen.... but if this is a bug ; then it should contain a testcase ! could you please add it? @kgyrtkirk As discussed offline, this PR has 2 parts: 1. Change to pass only window operator factories 2. Change in the logic to find shuffle spec A lot of the existing tests failed with only (1). They pass with (1) + (2). Hence existing tests suffice. So it's not a user-facing bug. But it's an incorrect logic which gets uncovered by (1), hence I called it a bug in the PR description. Happy to rephrase it if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
