adarshsanjeev commented on code in PR #16700:
URL: https://github.com/apache/druid/pull/16700#discussion_r1696671456
##########
processing/src/main/java/org/apache/druid/segment/column/LongsColumn.java:
##########
@@ -75,6 +77,13 @@ public long getLongSingleValueRow(int rowNum)
return column.get(rowNum);
}
+ @Override
+ @Nullable
+ public <T> T as(Class<? extends T> clazz)
+ {
+ return column.as(clazz);
Review Comment:
The class does not use SemanticUtils.makeAsMap so it would not be directly
overridable. I think the decision of using overrides or not currently belongs
to the class itself, in this way. The extension can still override it by adding
an override for ColumnarLongs which this class is pointing to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
