adarshsanjeev commented on code in PR #16700: URL: https://github.com/apache/druid/pull/16700#discussion_r1696695825
########## processing/src/main/java/org/apache/druid/segment/column/BaseColumn.java: ########## @@ -41,4 +42,11 @@ default VectorObjectSelector makeVectorObjectSelector(ReadableVectorOffset offse { throw new UOE("Cannot make VectorObjectSelector for column with class[%s]", getClass().getName()); } + + @SuppressWarnings("unused") + @Nullable + default <T> T as(Class<? extends T> clazz) + { + return null; Review Comment: The intention is to have implementations of base column be classes that have semantic creators and have possible conversions. Overrides can be registered against them. If a class does not have any conversion to another class, and does not override this function, it defaults to null. Adding a map and allowing functions to register overrides to it may cause it to use the conversions from the base class, if it is not overridden. I am not sure if that behavior is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org