ektravel commented on code in PR #16988:
URL: https://github.com/apache/druid/pull/16988#discussion_r1744329420


##########
docs/ingestion/ingestion-spec.md:
##########
@@ -515,13 +516,13 @@ For information on defining an `indexSpec` in a query 
context, see [SQL-based in
 
 |Field|Description|Default|
 |-----|-----------|-------|
-|bitmap|Compression format for bitmap indexes. Should be a JSON object with 
`type` set to `roaring` or `concise`.|`{"type": "roaring"}`|
-|dimensionCompression|Compression format for dimension columns. One of `lz4`, 
`lzf`, `zstd`, or `uncompressed`.|`lz4`|
-|stringDictionaryEncoding|Encoding format for string value dictionaries used 
by STRING and [COMPLEX<json>](../querying/nested-columns.md) columns. To 
enable front coding, set `stringDictionaryEncoding.type` to `frontCoded`. 
Optionally, you can specify the `bucketSize` and `formatVersion` properties. 
See [Front coding](#front-coding) for more information.|`{"type":"utf8"}`|
-|metricCompression|Compression format for primitive type metric columns. 
Options are `lz4`, `lzf`, `zstd`, `uncompressed`, or `none` (which is more 
efficient than `uncompressed`, but not supported by older versions of 
Druid).|`lz4`|
-|longEncoding|Encoding format for long-typed columns. Applies regardless of 
whether they are dimensions or metrics. Options are `auto` or `longs`. `auto` 
encodes the values using offset or lookup table depending on column 
cardinality, and store them with variable size. `longs` stores the value as-is 
with 8 bytes each.|`longs`|
-|complexMetricCompression|Compression format for complex type metric columns. 
Options are `lz4`, `lzf`, `zstd`, `uncompressed`. Options other than 
`uncompressed` are not compatible with Druid versions older than 31, and only 
applies to complex metrics which do not have specialized column 
formats.|`uncompressed`|
-|jsonCompression|Compression format to use for nested column raw data. Options 
are `lz4`, `lzf`, `zstd`, or `uncompressed`.|`lz4`|
+|`bitmap`|Compression format for bitmap indexes. Should be a JSON object with 
`type` set to `roaring` or `concise`.|`{"type": "roaring"}`|
+|`dimensionCompression`|Compression format for dimension columns. One of 
`lz4`, `lzf`, `zstd`, or `uncompressed`.|`lz4`|
+|`stringDictionaryEncoding`|Encoding format for string value dictionaries used 
by STRING and [COMPLEX<json>](../querying/nested-columns.md) columns. To 
enable front coding, set `stringDictionaryEncoding.type` to `frontCoded`. 
Optionally, you can specify the `bucketSize` and `formatVersion` properties. 
See [Front coding](#front-coding) for more information.|`{"type":"utf8"}`|
+|`metricCompression`|Compression format for primitive type metric columns. 
Options are `lz4`, `lzf`, `zstd`, `uncompressed`, or `none` (which is more 
efficient than `uncompressed`, but not supported by older versions of 
Druid).|`lz4`|

Review Comment:
   ```suggestion
   |`metricCompression`|Compression format for primitive type metric columns. 
One of `lz4`, `lzf`, `zstd`, `uncompressed`, or `none`. `none` is more 
efficient than `uncompressed`, but it's not supported by older versions of 
Druid.|`lz4`|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to