ektravel commented on code in PR #16988: URL: https://github.com/apache/druid/pull/16988#discussion_r1744353498
########## docs/ingestion/supervisor.md: ########## @@ -24,30 +24,40 @@ sidebar_label: Supervisor --> A supervisor manages streaming ingestion from external streaming sources into Apache Druid. -Supervisors oversee the state of indexing tasks to coordinate handoffs, manage failures, and ensure that the scalability and replication requirements are maintained. -This topic uses the Apache Kafka term offset to refer to the identifier for records in a partition. If you are using Amazon Kinesis, the equivalent is sequence number. +Supervisors oversee the state of indexing tasks to coordinate [handoffs](../design/storage#indexing-and-handoff), manage failures, and ensure that the scalability and replication requirements are maintained. -## Supervisor spec +:::info +This topic uses the Apache Kafka term _offset_ to refer to the identifier for records in a partition. If you are using Amazon Kinesis, the equivalent is _sequence number_. +::: -Druid uses a JSON specification, often referred to as the supervisor spec, to define streaming ingestion tasks. -The supervisor spec specifies how Druid should consume, process, and index streaming data. +Druid uses a JSON document, often referred to as a supervisor spec, to specify how Druid should consume, process, and index streaming data. A supervisor spec is a type of [native ingestion spec](../ingestion/ingestion-spec.md). The following table outlines the high-level configuration options for a supervisor spec: |Property|Type|Description|Required| |--------|----|-----------|--------| -|`type`|String|The supervisor type. One of `kafka`or `kinesis`.|Yes| -|`spec`|Object|The container object for the supervisor configuration.|Yes| -|`spec.dataSchema`|Object|The schema for the indexing task to use during ingestion. See [`dataSchema`](../ingestion/ingestion-spec.md#dataschema) for more information.|Yes| -|`spec.ioConfig`|Object|The I/O configuration object to define the connection and I/O-related settings for the supervisor and indexing tasks.|Yes| -|`spec.tuningConfig`|Object|The tuning configuration object to define performance-related settings for the supervisor and indexing tasks.|No| +|`type`|String|The type of ingestion to supervise, one of [`kafka`](kafka-ingestion.md) or [`kinesis`](kinesis-ingestion.md).|Yes| Review Comment: ```suggestion |`type`|String|The type of ingestion to supervise. One of [`kafka`](kafka-ingestion.md) or [`kinesis`](kinesis-ingestion.md).|Yes| ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
