kgyrtkirk commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1888200419
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -896,13 +933,12 @@ private SqlTestFramework(Builder builder)
// test pulls in a module, then pull in that module, even though we are
// not the Druid node to which the module is scoped.
.ignoreLoadScopes();
- List<Module> overrideModules = new ArrayList<>(builder.overrideModules);
- overrideModules.add(new LookylooModule());
- overrideModules.add(new SqlAggregationModule());
- overrideModules.add(new SegmentWranglerModule());
- overrideModules.add(new ExpressionModule());
+ ArrayList<Module> overrideModules = new
ArrayList<>(builder.overrideModules);
+
+ injectorBuilder.add(componentSupplier.getCoreModule());
overrideModules.add(testSetupModule());
+ overrideModules.add(componentSupplier.getOverrideModule());
Review Comment:
> The override modules need to be wholly owned and controlled by the test
setup
The test could alter the `componentSupplier` and that should be accessible
by it - this line should essentially just plug those overrides in.
If the test uses a custom componentsupplier; that could customize
`getOverrideModule` as well; if it has conflict with the ComponentSupplier its
being derived from with by `extends` ; it may use `Modules.override` to
override those - but I'll try to avoid the need for that; as that's just
ugly....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
