kgyrtkirk commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1888205347
##########
server/src/main/java/org/apache/druid/guice/DruidBinders.java:
##########
@@ -62,32 +66,68 @@ public static MapBinder<Class<? extends Query>, QueryLogic>
queryLogicBinderType
);
}
- public static QueryLogicBinder queryLogicBinder(Binder binder)
+ public static QueryBinder queryBinder(Binder binder)
{
- return new QueryLogicBinder(binder);
+ return new QueryBinder(binder);
}
- public static class QueryLogicBinder
+ public static class QueryBinder
Review Comment:
They can do whatever they want by using the `binder` directly.
I don't think they'll miss anything by not knowing about those things - it
just does the standard registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
