plainheart commented on code in PR #17426:
URL: https://github.com/apache/echarts/pull/17426#discussion_r946318069
##########
src/util/graphic.ts:
##########
@@ -63,7 +63,8 @@ import {
keys,
each,
hasOwn,
- isArray
+ isArray,
+ retrieve2
Review Comment:
Unused import.
##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -157,21 +159,26 @@ const axisElementBuilders: Record<typeof
selfBuilderAttrs[number], AxisElementBu
const colorIndex = (lineCount++) % lineColors.length;
const tickValue = ticksCoords[i].tickValue;
- axisGroup.add(new graphic.Line({
+ const line = new graphic.Line({
Review Comment:
It seems such changes made in previous commits can be restored.
##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -211,19 +217,24 @@ const axisElementBuilders: Record<typeof
selfBuilderAttrs[number], AxisElementBu
p2[1] = tickCoord;
}
- axisGroup.add(new graphic.Line({
+ const line = new graphic.Line({
Review Comment:
The same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
