pissang commented on code in PR #17426: URL: https://github.com/apache/echarts/pull/17426#discussion_r940968185
########## src/util/graphic.ts: ########## @@ -391,9 +399,13 @@ function isPath(el: Displayable): el is Path { export function groupTransition( g1: Group, g2: Group, - animatableModel: Model<AnimationOptionMixin> + animatableModel: Model<AnimationOptionMixin>, + done?: () => void ) { if (!g1 || !g2) { + if (typeof done === 'function') { Review Comment: `isFunction` utility can be used here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org