tyn1998 commented on code in PR #17611:
URL: https://github.com/apache/echarts/pull/17611#discussion_r961795876


##########
src/animation/universalTransition.ts:
##########
@@ -644,6 +765,7 @@ export function installUniversalTransition(registers: 
EChartsExtensionInstallReg
 
         // TODO multiple to multiple series.
         if (globalStore.oldSeries && params.updatedSeries && 
params.optionChanged) {
+            // TODO transitionOpt was used in an old implementation and can be 
removed now

Review Comment:
   Hi, @pissang.
   
   As you mentioned earlier that `transitionSeriesFromOpt` is an old 
implementation but not removed from code, should I remove related code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to