tyn1998 commented on code in PR #17611:
URL: https://github.com/apache/echarts/pull/17611#discussion_r962086893
##########
src/animation/universalTransition.ts:
##########
@@ -203,36 +318,22 @@ function transitionBetween(
if (onlyGetId) {
return data.getId(dataIndex);
}
-
- // Use group id as transition key by default.
- // So we can achieve multiple to multiple animation like drilldown
/ up naturally.
- // If group id not exits. Use id instead. If so, only one to one
transition will be applied.
- const dataGroupId = data.hostModel && (data.hostModel as
SeriesModel).get('dataGroupId') as string;
-
- // If specified key dimension(itemGroupId by default). Use this
same dimension from other data.
- // PENDING: If only use key dimension of newData.
- const keyDim = isOld
- ? (oldKeyDim || newKeyDim)
- : (newKeyDim || oldKeyDim);
Review Comment:
This fault-tolerance code is simply dropped. Because the code for getting
key from dimension(encode) is brought forward, where accessing both oldKeyDim
and newKeyDim is not convinient.
In my opinion, the code should better be dropped. Users should get
universalTransition working only if they satisfy all needs to trigger a
universalTransition as the
[doc](https://echarts.apache.org/zh/option.html#series-bar.universalTransition)
says. If they do not provide a perfect option but our code helps handling what
they miss to make universalTransition succeed, they might be confused once they
find "a bad option also triggers universalTransition", since they have no idea
that echarts developers write fault-tolerance code to help with their bad
options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
