plainheart commented on code in PR #17849: URL: https://github.com/apache/echarts/pull/17849#discussion_r1011298445
########## src/component/toolbox/feature/DataView.ts: ########## @@ -534,4 +540,14 @@ echarts.registerAction({ }, payload.newOption)); }); +echarts.registerAction( + { type: 'openDataView', event: 'dataViewOpend' }, Review Comment: @Ovilia @MainHou I noticed the registered action doesn't respond to the corresponding command from the developer. That is, this PR is only for the event but not for action, which causes the developer can't open or close the data view programmatically. I think it makes sense to support this feature. ```js // show the data view programmatically myChart.dispatchAction({ type: 'showDataView' }) // hide the data view programmatically myChart.dispatchAction({ type: 'hideDataView' }) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org