Ovilia commented on code in PR #18820:
URL: https://github.com/apache/echarts/pull/18820#discussion_r1251449060
##########
src/chart/pie/pieLayout.ts:
##########
@@ -113,12 +116,19 @@ export default function pieLayout(
const extent = data.getDataExtent(valueDim);
extent[0] = 0;
+ const dir = clockwise ? 1 : -1;
+ const angles = [startAngle, endAngle];
+ normalizeArcAngles(angles, !clockwise);
+
+ [startAngle, endAngle] = angles;
+
+ const angleRange = Math.abs(endAngle - startAngle);
Review Comment:
I don't think we need `Math.abs` here since `normalizeArcAngles` has done
the job to normalize them to make sure `endAngle` is larger. And this will look
the same as
[GaugeView](https://github.com/apache/echarts/blob/master/src/chart/gauge/GaugeView.ts#L122-L126).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
