linghaoSu commented on code in PR #18820:
URL: https://github.com/apache/echarts/pull/18820#discussion_r1251468653
##########
src/chart/pie/pieLayout.ts:
##########
@@ -113,12 +116,19 @@ export default function pieLayout(
const extent = data.getDataExtent(valueDim);
extent[0] = 0;
+ const dir = clockwise ? 1 : -1;
+ const angles = [startAngle, endAngle];
+ normalizeArcAngles(angles, !clockwise);
+
+ [startAngle, endAngle] = angles;
+
+ const angleRange = Math.abs(endAngle - startAngle);
Review Comment:
From my local test, normalizeArcAngles not make endAgnle larger when
anticlockwise
<img width="1798" alt="image"
src="https://github.com/apache/echarts/assets/56526981/a80eadfd-545b-490c-9e67-578dfc2a467a";>
and in `normalizeArcAngles` comment, that has should be negative when
anticlockwise, but now is positive, so I have to add abs here, to avoid get a
negative range.
<img width="644" alt="image"
src="https://github.com/apache/echarts/assets/56526981/def20657-8706-4585-b802-0f50d31abdde";>
If there is a zrender bug here, may be we should add abs to here for now.
and after this 'bug'(maybe) fixed, then remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
