robin-gerling commented on PR #19534:
URL: https://github.com/apache/echarts/pull/19534#issuecomment-2264863931
The `test/custom-shape-morphing2.html`looks different because the axis names
are currently not included in the grid. With the new version, they are included
and therefore decrease the size of the grid.
The green frame indicates the `gridRect` (with the default margins) before
the calculations in `if (containLabel) {` (red frame afterwards). Therefore,
with the current behaviour, the names would not be visible for a grid margin of
e.g. 0.
<img width="1080" alt="CurrentBehaviour"
src="https://github.com/user-attachments/assets/0537517f-632c-4d30-b233-8b9575fcdf75";>
<img width="1061" alt="NewBehaviour"
src="https://github.com/user-attachments/assets/d2a73a0d-6bee-4ffe-aa5a-7063801ee217";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
