Ovilia commented on code in PR #20718:
URL: https://github.com/apache/echarts/pull/20718#discussion_r1986669507
##########
src/component/dataZoom/AxisProxy.ts:
##########
@@ -271,7 +271,22 @@ class AxisProxy {
const valueWindow = this._valueWindow;
if (filterMode === 'none') {
- return;
+ each(seriesModels, function (seriesModel) {
+ if (seriesModel.subType === 'bar' || seriesModel.subType ===
'scatter') {
Review Comment:
It may not be a good idea to check `subType` here because AxisProxy should
have no idea of what series type is. These logic should probably be implemented
in their own series code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
