100pah commented on PR #20865: URL: https://github.com/apache/echarts/pull/20865#issuecomment-2846630714
@Ovilia Great design and the very detailed explanation! And I only list some issues I come up with: ### backward compatibility A theme of echarts v5 is needed if v6 modify the default settings. The new design changes numerous default position and size settings. Users typically use a mix of default settings and custom configurations. Therefore if upgrading to v6 break the layout and appearance and require significant effort to restore, it may discourage users to upgrade. ### Regarding the colors I'm just describing my first intuitive feelings - not a professional or serious test, and others may have opposite feelings. Therefore this is just a minor point of reference. #### The 1st color I feel the new version is great. #### The 2nd color I prefer the v5 slightly, because I feel the new version is a bit too "sharp" or "shiny" (or over saturated?) - especially over large areas. A "shiny" color can feel tiring to look at after a time in front of the screen. <img width="846" alt="image" src="https://github.com/user-attachments/assets/4b845b05-57e9-4592-8c68-3c66b6dca9e8"; /> And a light color make its corresponding label less visible. The label color has the same color if outside, be white color in inside - both of them are less visible: <img width="958" alt="image" src="https://github.com/user-attachments/assets/6eb15121-fed6-44e9-bd27-626ec1bf8aa4"; /> <img width="961" alt="image" src="https://github.com/user-attachments/assets/501b6b9e-5770-42ca-8f31-77d5c1530300"; /> #### The 3rd color The 3rd color has a significant change. I'm worried about the new version is too close to greyscale colors. From my understanding, the greyscale colors are preferable to be used in auxiliary components, such as axis and labels/texts, while chromatic colors are typically used in shapes/glyphs that represents data. All of the other colors seem to conform with that idea, except the new version of the 3rd color. And if it is used over a large area, it gives a feeling that conbinating grayscale and color-scale colors - a bit disharmonious. #### Regarding the highlight/emphasis color of map I think this is a significant change from a yellow to grey. I personally strongly prefer the v5 version yellow. That color serves both "hovering-highlight" and "select" - especially in mobile, there is no "hovering" but only "select". If changed to a grey, the selected regions will be less visable. And if only regarding the hovering, the original yellow is noticeable. I think "the yellow is inconsistent with the overall design" is not a concern, since users typically use map individually and do not combinate maps with other types of chart. And actually I can not feel that inconsistency - the original yellow is still harmony. <img width="885" alt="image" src="https://github.com/user-attachments/assets/a72cc724-6688-41f8-b261-f3d2e8bdba7b"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
