100pah commented on code in PR #20865:
URL: https://github.com/apache/echarts/pull/20865#discussion_r2118055721
##########
test/runTest/client/client.js:
##########
@@ -156,17 +197,34 @@ const app = new Vue({
runConfig: Object.assign({
sortBy: 'name',
- actualVersion: null,
+ actualVersion: 'local',
Review Comment:
I think this modification is not correct.
After this change, the initial state will be:
<img width="657" alt="image"
src="https://github.com/user-attachments/assets/3961dc29-899a-464b-b998-b9987800eaa1";
/>
The actual "Release" is not supposed to have a "local" branch.
I used to fix that issue in 365f33be8982ce1055dac5ffa40fdf6c03bd489d , but
this change it back. Is it intentional?
I think in most cases the "actual" should be local, rather than release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
