Ovilia commented on code in PR #20865:
URL: https://github.com/apache/echarts/pull/20865#discussion_r2097276668
##########
src/coord/calendar/CalendarModel.ts:
##########
@@ -36,6 +36,7 @@ import {
} from '../../util/types';
import GlobalModel from '../../model/Global';
import Model from '../../model/Model';
+import tokens from '../../visual/tokens';
Review Comment:
Changed the year label to be a lighter gray, but not as light as v5. I don't
quite believe we should make it lighter since it's larger. It's larger because
it's more prominant, so it gives more reason to make it darker.
<img width="1150" alt="image"
src="https://github.com/user-attachments/assets/8920f0e2-1106-4839-846d-0e1393cd25e5";
/>
Dark background should not be considered in this case. If user wants to use
dark background, he, or the one who makes the dark theme should be responsible
for changing the label colors to fit the background. And whatever color you
choose for the default label, it's still possible that the user set the
background to a similar color (a black background for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
