Ovilia commented on code in PR #21081:
URL: https://github.com/apache/echarts/pull/21081#discussion_r2214745897
##########
test/radar.html:
##########
@@ -19,119 +18,144 @@
-->
<html>
- <head>
- <meta charset="utf-8">
- <script src="lib/simpleRequire.js"></script>
- <script src="lib/config.js"></script>
- </head>
- <body>
- <style>
- html, body, #main {
- width: 100%;
- height: 100%;
- }
- </style>
- <div id="main"></div>
- <script>
- require([
- 'echarts'
- ], function (echarts) {
+<head>
+ <meta charset="utf-8">
+ <script src="lib/simpleRequire.js"></script>
+ <script src="lib/config.js"></script>
+</head>
+
+<body>
+ <style>
+ html,
+ body,
+ #main {
+ width: 100%;
+ height: 100%;
+ }
+ </style>
+ <div id="main"></div>
+ <script>
+
+ require([
+ 'echarts'
+ ], function (echarts) {
Review Comment:
Again, please revert the changes of indent. If you are using auto-formatting
tools, you may need to disable it.
##########
src/chart/radar/RadarView.ts:
##########
@@ -177,92 +177,108 @@ class RadarView extends ChartView {
})
.execute();
- data.eachItemGraphicEl(function (itemGroup: graphic.Group, idx) {
- const itemModel =
data.getItemModel<RadarSeriesDataItemOption>(idx);
- const polyline = itemGroup.childAt(0) as graphic.Polyline;
- const polygon = itemGroup.childAt(1) as graphic.Polygon;
- const symbolGroup = itemGroup.childAt(2) as graphic.Group;
- // Radar uses the visual encoded from itemStyle.
- const itemStyle = data.getItemVisual(idx, 'style');
- const color = itemStyle.fill;
-
- group.add(itemGroup);
-
- polyline.useStyle(
- zrUtil.defaults(
- itemModel.getModel('lineStyle').getLineStyle(),
- {
- fill: 'none',
- stroke: color
+ data.eachItemGraphicEl(function (itemGroup: graphic.Group, idx) {
Review Comment:
Please don't change the indent if there's no problem with the old code. It
makes the diff hard to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
