100pah commented on code in PR #21201:
URL: https://github.com/apache/echarts/pull/21201#discussion_r2384424259
##########
src/model/Global.ts:
##########
@@ -1039,7 +1035,9 @@ function mergeTheme(option: ECUnitOption, theme:
ThemeOption): void {
if (typeof themeItem === 'object') {
option[name] = !option[name]
? clone(themeItem)
- : merge(option[name], themeItem, false);
+ : preserveUserOptions
+ ? merge(themeItem, option[name], false) // User
options have higher priority
Review Comment:
Currently, I think the quick fix proposed should not be applied, since it
brings more bugs that cannot to be fixed.
> So it seems that if we need to solve this problem now
Could you explain the original scenario where you need to use setTheme while
keeping data?
I’d like to determine whether this usage is appropriate, and whether a major
refactor is worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
