100pah commented on PR #21390:
URL: https://github.com/apache/echarts/pull/21390#issuecomment-3719985580
@natsuokawai @Ovilia
I made a commit and modified:
+ Both `cellRect` (typically non-transparent) and `cellText` may trigger
events, depending on both `matrix.triggerEvent`, `matrix.xxx.silent` and
`matrix.xxx.label.silent` settings. By default (`matrix.triggerEvent:true`,
`matrix.xxx.silent` and `matrix.xxx.label.silent` is not specified or
`null/undefined`) cell text and non-transparent cell background trigger events.
If intending to disable cell background triggering, set `matrix.xxx.silent:
true`.
[NOTE]: `matrix.xxx.silent` and `matrix.xxx.label.silent` (missing in doc)
have been used to control the interactive of `cellRect` and `cellText`
separately since `v6.0.0`. Therefore I think the new `triggerEvent` can follow
this pattern, as long as it is not inappropriate.
+ Modify event param:
+ `name` is the final rendered text
+ `value` is the original input cell value in option.
+ Add visual test cases for `matrix.html`.
And I've changed the merge target to "release" for the upcoming `v6.1.0`.
`v6.1.0` is in testing, so I modify the code directly; sorry for that.
If any of the change is inappropriate, we can discuss them further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
