Ovilia commented on code in PR #21390:
URL: https://github.com/apache/echarts/pull/21390#discussion_r2605403936
##########
src/component/matrix/MatrixView.ts:
##########
@@ -359,6 +365,18 @@ function createMatrixCell(
}
cellRect.silent = rectSilent;
+ if (triggerEvent && cellText) {
+ const eventData = {
+ componentType: 'matrix' as const,
+ componentIndex: matrixModel.componentIndex,
+ matrixIndex: matrixModel.componentIndex,
+ targetType: targetType,
+ name: textValue != null ? textValue + '' : null,
+ coord: xyLocator.slice()
+ };
+ getECData(cellText).eventData = eventData;
+ }
Review Comment:
I also have this doubt. @natsuokawai Do you think it be useful to cells
without text to trigger events?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
