Justin-ZS commented on code in PR #20495:
URL: https://github.com/apache/echarts/pull/20495#discussion_r3099392527
##########
test/line-scale.html:
##########
@@ -0,0 +1,61 @@
+
+<!DOCTYPE html>
+<html>
+<head>
+ <meta charset="utf-8">
+ <title>Line Scale Test</title>
+ <script src="lib/simpleRequire.js"></script>
+ <script src="lib/config.js"></script>
+</head>
+<body>
+ <style>
+ html, body, #main {
+ width: 100%;
+ height: 100%;
+ margin: 0;
+ }
+ </style>
+
+ <div id="main"></div>
+
+ <script>
+ require(['echarts'], function (echarts) {
+ var chart = echarts.init(document.getElementById('main'));
+
+ var option = {
+ title: {
+ text: 'Line Scale',
+ left: 'center'
+ },
+ dataset: {
+ source: [
+ ['x', 'y'],
+ [1, 10],
+ [2, 20],
+ [3, 30],
+ [4, 40],
+ [5, 50]
+ ]
+ },
+ xAxis: {
+ type: 'category'
+ },
+ yAxis: {
+ type: 'value'
+ },
+ dataZoom: [{
+ type: 'slider',
+ start: 40,
+ end: 50,
+ filterMode: 'empty'
Review Comment:
[P2] 回归用例没有覆盖 PR 声称修复的 `filterMode: none` 场景。
这个用例只配置了 `filterMode: empty`，但 PR 标题/描述同时声称修复了 `none`，还把 #19666
也算进了修复范围。当前没有任何 case 能证明 `none` 路径不会再次回归，所以至少需要补一条 `filterMode: none`
的场景；如果继续保留 #19666，最好再带上 bar 系列的用例。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
