SEPURI-SAI-KRISHNA commented on PR #21735: URL: https://github.com/apache/echarts/pull/21735#issuecomment-5658066963
Following up now that the other three have landed, this one is still open against `master`. On the #18491 overlap I noted above: that PR has had an unresolved `CHANGES_REQUESTED` since 2023-06-25 and its branch hasn't been pushed since 2024-07, while #18448 is still open. So the `removeNodeEdge` crash is still live in 6.1.x. If #18491 isn't close to landing, the one-line guard here fixes that crash in the meantime, and if #18491 does land later it only needs a trivial rebase of that line. The empty-data crash is independent of #18491 either way, `bbox.fromPoints` leaves `min`/`max` empty, the dataRect comes out `NaN`, and the resulting view transform is singular. `src/chart/tree/TreeView.ts` is identical on `master` and `release`, so I'm happy to rebase this onto `release` for 6.1.1, or to drop the `removeNodeEdge` hunk and keep this scoped to the empty-data fix. Whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
