vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573419177 The `ShareAccountIntegrationTests.testCreateShareAccountWithCharges()` failure was related to `ShareAccountCharge`, something is really wrong there... to move forward with getting all the rest of the changes proposed here merged ASAP, I've reverted the `hashCode()` and `equals()` changes in `ShareAccountCharge` from here for now; let's pick that up in dedicated [FINERACT-827](https://issues.apache.org/jira/browse/FINERACT-827). With that, I expect that this PR will now pass CI IT (unless it's Sunday, in which case it will fail due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820), which is totally unrelated to everything else here).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
