vorburger opened a new pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684 based upon code review of changes made by @awasum in previous commit: - fix clear contains() GC_UNRELATED_TYPES bug in Loan - fix clear equals() EC_UNRELATED_TYPES bug in Loan - fix more equals() & hashCode() in... * Charge * TrialBalance * LoanProductBorrowerCycleVariations * LoanProductProvisioningEntry - fix AccountingConstants to avoid using @FindBugsSuppressWarnings - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings - fix up weird static in GLAccountBuilder - minor clean up in build.gradle (spotbugs has replaced findbugs) PS: This change originally included also fixing the missing `hashCode()` and `equals()` in `ShareAccountCharge`, but that turned out to be non trivial, see [FINERACT-827](https://issues.apache.org/jira/browse/FINERACT-827), and is thus not yet fixed by this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
