thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491843079
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java
##########
@@ -624,11 +624,11 @@ public String retrieveGsimAccounts(@PathParam("groupId")
final Long groupId,
}
- final Set<String> GSIM_ACCOUNTS_DATA_PARAMETERS = new HashSet<>(
+ final Set<String> glimAccountsDataParameters = new HashSet<>(
Arrays.asList("gsimId", "groupId", "accountNumber",
"childGSIMAccounts", "parentBalance", "savingsStatus"));
Review comment:
updated, thanks for finding this.
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositProductHelper.java
##########
@@ -244,8 +244,8 @@ public static ArrayList
retrieveAllRecurringDepositProducts(final RequestSpecifi
public static HashMap retrieveRecurringDepositProductById(final
RequestSpecification requestSpec,
final ResponseSpecification responseSpec, final String productId) {
LOG.info("-------------------- RETRIEVING RECURRING DEPOSIT PRODUCT BY
ID --------------------------");
- final String GET_RD_PRODUCT_BY_ID_URL = RECURRING_DEPOSIT_PRODUCT_URL
+ "/" + productId + "?" + Utils.TENANT_IDENTIFIER;
- final HashMap response = Utils.performServerGet(requestSpec,
responseSpec, GET_RD_PRODUCT_BY_ID_URL, "");
+ final String getRDproductByIDurl = RECURRING_DEPOSIT_PRODUCT_URL + "/"
+ productId + "?" + Utils.TENANT_IDENTIFIER;
Review comment:
updated.
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositAccountHelper.java
##########
@@ -156,9 +156,9 @@ public static Integer
applyRecurringDepositApplication(final String recurringDep
public static HashMap getRecurringDepositAccountById(final
RequestSpecification requestSpec, final ResponseSpecification responseSpec,
final Integer accountID) {
- final String GET_RECURRING_DEPOSIT_BY_ID_URL =
RECURRING_DEPOSIT_ACCOUNT_URL + "/" + accountID + "?" + Utils.TENANT_IDENTIFIER;
+ final String getRecurringDepositByIDurl =
RECURRING_DEPOSIT_ACCOUNT_URL + "/" + accountID + "?" + Utils.TENANT_IDENTIFIER;
Review comment:
updated.
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/organisation/CampaignsHelper.java
##########
@@ -53,50 +53,50 @@ public CampaignsHelper(final RequestSpecification
requestSpec, final ResponseSpe
public Integer createCampaign(String reportName, Integer triggerType) {
LOG.info("---------------------------------CREATING A
CAMPAIGN---------------------------------------------");
- final String CREATE_SMS_CAMPAIGNS_URL = SMS_CAMPAIGNS_URL + "?" +
Utils.TENANT_IDENTIFIER;
- return Utils.performServerPost(requestSpec, responseSpec,
CREATE_SMS_CAMPAIGNS_URL, getCreateCampaignJSON(reportName, triggerType),
+ final String createSMScampaignsURL = SMS_CAMPAIGNS_URL + "?" +
Utils.TENANT_IDENTIFIER;
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
