thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491846062



##########
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HolidayHelper.java
##########
@@ -77,15 +77,15 @@ public static Integer createHolidays(final 
RequestSpecification requestSpec, fin
 
     public static Integer activateHolidays(final RequestSpecification 
requestSpec, final ResponseSpecification responseSpec,
             final String holidayID) {
-        final String ACTIVATE_HOLIDAY_URL = HOLIDAYS_URL + "/" + holidayID + 
"?command=activate&" + Utils.TENANT_IDENTIFIER;
-        return Utils.performServerPost(requestSpec, responseSpec, 
ACTIVATE_HOLIDAY_URL, getActivateHolidayDataAsJSON(), "resourceId");
+        final String activateHolidayURL = HOLIDAYS_URL + "/" + holidayID + 
"?command=activate&" + Utils.TENANT_IDENTIFIER;
+        return Utils.performServerPost(requestSpec, responseSpec, 
activateHolidayURL, getActivateHolidayDataAsJSON(), "resourceId");
     }
 
     public static HashMap getHolidayById(final RequestSpecification 
requestSpec, final ResponseSpecification responseSpec,
             final String holidayID) {
-        final String GET_HOLIDAY_BY_ID_URL = HOLIDAYS_URL + "/" + holidayID + 
"?" + Utils.TENANT_IDENTIFIER;
+        final String getHolidayByIDurl = HOLIDAYS_URL + "/" + holidayID + "?" 
+ Utils.TENANT_IDENTIFIER;
         LOG.info("------------------------ RETRIEVING HOLIDAY BY ID 
-------------------------");

Review comment:
       upated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to