adamsaghy commented on code in PR #2436:
URL: https://github.com/apache/fineract/pull/2436#discussion_r939995146
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -1573,21 +1576,36 @@ public void
validateAccountBalanceDoesNotBecomeNegative(final String transaction
throw new
PlatformApiDataValidationException(dataValidationErrors);
}
}
-
}
lastSavingsDate = transaction.transactionLocalDate();
-
}
- BigDecimal withdrawalFee = null;
- BigDecimal transactionAmount = null;
if (isOverdraft()) {
if (runningBalance.minus(minRequiredBalance).isLessThanZero()) {
- throw new
InsufficientAccountBalanceException("transactionAmount", getAccountBalance(),
withdrawalFee, transactionAmount);
+ overdraftLimitExceededException("transactionAmount",
getAccountBalance(), transactionAmount);
+ }
+ }
+ }
+
+ public void validateAccountBalanceDoesNotViolateOverdraft(final
List<SavingsAccountTransaction> savingsAccountTransaction,
+ final BigDecimal amountPaid) {
+ if (savingsAccountTransaction != null) {
+ SavingsAccountTransaction savingsAccountTransactionFirst =
savingsAccountTransaction.get(0);
Review Comment:
@francisguchie In that case i would rather rely on the account balance
instead of trying to figure out which transaction was the very last and what is
the running balance of it. I mean both could work and i believe both of them
should be always the same (hopefully).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
