vidakovic commented on code in PR #2436:
URL: https://github.com/apache/fineract/pull/2436#discussion_r951208686
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransactionRepository.java:
##########
@@ -49,4 +50,8 @@ List<SavingsAccountTransaction>
findTransactionRunningBalanceBeforePivotDate(@Pa
@Query("select sat from SavingsAccountTransaction sat where sat.refNo =
:refNo")
Review Comment:
@rrpawar96 ... why is that additional @Query annotation needed here? Should
just work the same way if you rename the function to "findByRefNo"... and is
shorter... and you just have to "maintain" one thing (the function name). For
short queries (i. e. not too many parameters) I think using the repository
function magic is nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
