josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041317869
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ########## @@ -224,12 +227,11 @@ public class Client extends AbstractAuditableWithUTCDateTimeCustom { @OneToMany(mappedBy = "client", cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.LAZY) private Set<ClientCollateralManagement> clientCollateralManagements = new HashSet<>(); - public static Client createNew(final AppUser currentUser, final Office clientOffice, final Group clientParentGroup, final Staff staff, + public static Client instance(final AppUser currentUser, final Office clientOffice, final Group clientParentGroup, final Staff staff, final Long savingsProductId, final CodeValue gender, final CodeValue clientType, final CodeValue clientClassification, - final Integer legalForm, final JsonCommand command) { + final Integer legalForm, final ExternalId externalId, final JsonCommand command) { Review Comment: Done, Interface and Service created `ClientDomainService` ########## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ########## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return ClientStatus.fromInt(this.status).isWithdrawn(); } - public Map<String, Object> update(final JsonCommand command) { + public Map<String, Object> update(final ExternalId externalId, final JsonCommand command) { Review Comment: Done, Interface and Service created `ClientDomainService` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org