adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041379158
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ########## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return ClientStatus.fromInt(this.status).isWithdrawn(); } - public Map<String, Object> update(final JsonCommand command) { + public Map<String, Object> update(final ExternalId externalId, final JsonCommand command) { Review Comment: i thought you will move this logic into the only service which calls it... :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org