[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

[GitBox]

josehernandezfintecheandomx commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1046086290


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java:
##########
@@ -545,90 +543,77 @@ public ClientData mapRow(final ResultSet rs, final int 
rowNum) throws SQLExcepti
         }
     }
 
-    @Override
-    public Collection<ClientData> retrieveActiveClientMembersOfCenter(final 
Long centerId) {
-
-        final AppUser currentUser = this.context.authenticatedUser();
-        final String hierarchy = currentUser.getOffice().getHierarchy();
-        final String hierarchySearchString = hierarchy + "%";
-
-        final String sql = "select " + this.membersOfGroupMapper.schema()
-                + " left join m_group g on pgc.group_id=g.id where o.hierarchy 
like ? and g.parent_id = ? and c.status_enum = ? group by c.id";
-
-        return this.jdbcTemplate.query(sql, this.membersOfGroupMapper, // 
NOSONAR
-                hierarchySearchString, centerId, 
ClientStatus.ACTIVE.getValue());
-    }
-
-    private static final class ClientMapper implements RowMapper<ClientData> {
+    private static final class ClientMembersOfGroupMapper implements 
RowMapper<ClientData> {
 
         private final String schema;
 
-        ClientMapper() {
-            final StringBuilder builder = new StringBuilder(400);
+        ClientMembersOfGroupMapper() {
+            final StringBuilder sqlBuilder = new StringBuilder(200);

Review Comment:
   The variable never was renamed, Please take a look of the next screenshot to 
you can see the git diff is getting that difference...
   
   <img width="1034" alt="Screenshot 2022-12-12 at 10 46 22" 
src="https://user-images.githubusercontent.com/44206706/207104159-1d323868-6f99-4f3c-a1f6-ad2def054f02.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org