adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java:
##########
@@ -1485,7 +1486,7 @@ public LoanAccountData
retrieveClientDetailsTemplate(final Long clientId) {
final LocalDate expectedDisbursementDate =
DateUtils.getBusinessLocalDate();
return LoanAccountData.clientDefaults(clientAccount.getId(),
clientAccount.getAccountNo(), clientAccount.getDisplayName(),
- clientAccount.getOfficeId(), clientAccount.getExternalId(),
expectedDisbursementDate);
+ clientAccount.getOfficeId(),
clientAccount.getExternalId().getValue(), expectedDisbursementDate);
Review Comment:
Please undo the changes you done in the `LoanAccountData` and **only**
change the `clientExternalId` as i asked. Please do not change the loan
externalid as it was not part of this story and we will conflict.
You have modified the `externalId` field which should have been left AS-IS,
it's part of my story to change that and you havent changed the
`clientExternalId` which was part of your story. Please undo these latest
changes and change only the `clientExternalId` field in the `LoanAccountData`
@josehernandezfintecheandomx is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
