[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

[GitBox]

josehernandezfintecheandomx commented on code in PR #2797:
URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java:
##########
@@ -213,6 +213,10 @@ private Money cumulativePenaltyChargesDueWithin(final 
LocalDate periodStart, fin
                     cumulative = cumulative.plus(loanChargeAmt);
                 } else if 
(loanCharge.isDueForCollectionFromAndUpToAndIncluding(periodStart, periodEnd)) {
                     cumulative = cumulative.plus(loanCharge.amount());
+                    // Special case for Loan Charges (Due Date) added the same 
disbursement date
+                } else if (period.isFirstPeriod()

Review Comment:
   Well, It can be implemented in different ways. This one was used for the 
Fees in the previous change and now is the same code in the Penalties method. 
Plus the logic for validating the dates was reusing the same functions.
   
   Based on that, I've updated the code as you suggest and I've removed the 
code added in the previous change that is not more needed. @adamsaghy 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org