josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ########## @@ -213,6 +213,10 @@ private Money cumulativePenaltyChargesDueWithin(final LocalDate periodStart, fin cumulative = cumulative.plus(loanChargeAmt); } else if (loanCharge.isDueForCollectionFromAndUpToAndIncluding(periodStart, periodEnd)) { cumulative = cumulative.plus(loanCharge.amount()); + // Special case for Loan Charges (Due Date) added the same disbursement date + } else if (period.isFirstPeriod() Review Comment: Well, It can be implemented in different ways. This one was used for the Fees in the previous change and now is the same code in the Penalties method. Plus the logic for validating the dates was reusing the same functions. Based on that, I've updated the code as you suggest and I've removed the code added in the previous change that is not more needed. @adamsaghy <img width="1077" alt="Screenshot 2022-12-12 at 22 20 00" src="https://user-images.githubusercontent.com/44206706/207225728-23cab1e3-898b-4e8e-baf6-0892d6344d6b.png"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org