adamsaghy commented on code in PR #3973:
URL: https://github.com/apache/fineract/pull/3973#discussion_r1679173186
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -205,35 +212,45 @@ else if
(savingsTransactionDTO.getTransactionType().isFeeDeduction() && savingsT
savingsProductId, paymentTypeId, savingsId,
transactionId, transactionDate, overdraftAmount, isReversal,
penaltyPayments);
if (isPositive) {
+ final ChargePaymentDTO chargePaymentDTO =
penaltyPayments.get(0);
+ AccrualAccountsForSavings accountTypeToBeDebited =
AccrualAccountsForSavings.SAVINGS_CONTROL;
Review Comment:
I am not sure why to put this into a variable. The credit pair was inline in
the method... :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
