adamsaghy commented on code in PR #3973:
URL: https://github.com/apache/fineract/pull/3973#discussion_r1679189605


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResourceSwagger.java:
##########
@@ -233,6 +235,33 @@ private PostSavingsAccountsRequest() {}
         public String submittedOnDate;
         @Schema(example = "123")
         public String externalId;
+        @Schema(example = "5.0")

Review Comment:
   Please dont use `Double`. It is either whole number and Integer / Long or 
BigDecimal to support fractions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to