adamsaghy commented on code in PR #4109:
URL: https://github.com/apache/fineract/pull/4109#discussion_r1807763075
##########
fineract-progressive-loan/src/test/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleGeneratorTest.java:
##########
@@ -87,7 +71,7 @@ void testGenerateLoanSchedule() {
ScheduledDateGenerator mockScheduledDateGenerator =
Mockito.mock(ScheduledDateGenerator.class);
ProgressiveLoanScheduleGenerator generator = new
ProgressiveLoanScheduleGenerator(mockScheduledDateGenerator, emiCalculator);
- when(mockScheduledDateGenerator.generateRepaymentPeriods(any(), any(),
any())).thenReturn(expectedRepaymentPeriods);
+ when(mockScheduledDateGenerator.generateRepaymentPeriods(any(), any(),
any(), any())).thenReturn(expectedRepaymentPeriods);
Review Comment:
Please dont do any mocks... we should be able to generate the loan schedule
without any mocking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
