galovics commented on code in PR #4109: URL: https://github.com/apache/fineract/pull/4109#discussion_r1808338188
########## fineract-core/src/main/java/org/apache/fineract/organisation/monetary/domain/Money.java: ########## @@ -18,27 +18,21 @@ */ package org.apache.fineract.organisation.monetary.domain; -import jakarta.persistence.Column; -import jakarta.persistence.Embeddable; import java.math.BigDecimal; +import java.math.MathContext; import java.math.RoundingMode; import java.util.Iterator; +import lombok.Getter; import org.apache.fineract.organisation.monetary.data.CurrencyData; -@Embeddable Review Comment: Isn't this going to be a breaking change? Is there any JPA entity using this class as an embeddable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
