adamsaghy commented on code in PR #4837:
URL: https://github.com/apache/fineract/pull/4837#discussion_r2213097113
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformServiceImpl.java:
##########
@@ -422,6 +426,17 @@ public List<ChargeData>
retrieveSavingsProductCharges(final Long savingsProductI
return this.jdbcTemplate.query(sql, rm, new Object[] {
savingsProductId }); // NOSONAR
}
+ @Override
Review Comment:
Dont use native queries! Use JPQL!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeReadPlatformServiceImpl.java:
##########
@@ -294,6 +294,10 @@ public String savingsProductChargeSchema() {
return chargeSchema() + " join m_savings_product_charge spc on
spc.charge_id = c.id";
}
+ public String savingsProductAccrualChargeSchema() {
+ return chargeSchema() + " join m_savings_product_accrual_charge
spc on spc.charge_id = c.id";
Review Comment:
Dont use native queries! Use JPQL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
