adamsaghy commented on code in PR #4837:
URL: https://github.com/apache/fineract/pull/4837#discussion_r2213109008
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -60,27 +62,62 @@ public SavingsAccountData postInterest(final MathContext
mc, final LocalDate int
final LocalDate postInterestOnDate, final boolean
backdatedTxnsAllowedTill, final SavingsAccountData savingsAccountData) {
Money interestPostedToDate =
Money.zero(savingsAccountData.getCurrency());
LocalDate startInterestDate =
getStartInterestCalculationDate(savingsAccountData);
-
if (backdatedTxnsAllowedTill &&
savingsAccountData.getSummary().getInterestPostedTillDate() != null) {
interestPostedToDate = Money.of(savingsAccountData.getCurrency(),
savingsAccountData.getSummary().getTotalInterestPosted());
savingsAccountData.setStartInterestCalculationDate(savingsAccountData.getSummary().getInterestPostedTillDate());
} else {
savingsAccountData.setStartInterestCalculationDate(startInterestDate);
}
-
final List<PostingPeriod> postingPeriods = calculateInterestUsing(mc,
interestPostingUpToDate, isInterestTransfer,
isSavingsInterestPostingAtCurrentPeriodEnd,
financialYearBeginningMonth, postInterestOnDate, backdatedTxnsAllowedTill,
savingsAccountData);
-
boolean recalucateDailyBalanceDetails = false;
boolean applyWithHoldTax =
isWithHoldTaxApplicableForInterestPosting(savingsAccountData);
final List<SavingsAccountTransactionData> withholdTransactions = new
ArrayList<>();
withholdTransactions.addAll(findWithHoldSavingsTransactionsWithPivotConfig(savingsAccountData));
+ Boolean flagValidationInterest = false;
Review Comment:
what are these flags for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
