adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2259790343
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -100,6 +100,7 @@ public void mergeProductToAccountMappingChanges(final
JsonElement element, final
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditInterestAccountId");
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditFeesAccountId");
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditPenaltyAccountId");
+
optionalProductToGLAccountMappingEntries.add("interestReceivableAccountId");
Review Comment:
This should be part of https://github.com/apache/fineract/pull/4876 no?
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java:
##########
@@ -358,6 +358,8 @@ private Map<String, Object>
setAccrualPeriodicSavingsProductToGLAccountMaps(fina
// Assets
if
(glAccountForSavings.equals(AccrualAccountsForSavings.SAVINGS_REFERENCE)) {
accountMappingDetails.put(SavingProductAccountingDataParams.SAVINGS_REFERENCE.getValue(),
glAccountData);
+ } else if
(glAccountForSavings.equals(AccrualAccountsForSavings.INTEREST_RECEIVABLE)) {
Review Comment:
This should be part of https://github.com/apache/fineract/pull/4876 no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
