adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2259797299


##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -185,6 +185,11 @@ else if 
(savingsTransactionDTO.getTransactionType().isAccrual()) {
                     
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office, 
currencyCode,
                             
AccrualAccountsForSavings.INTEREST_ON_SAVINGS.getValue(), 
AccrualAccountsForSavings.INTEREST_PAYABLE.getValue(),
                             savingsProductId, paymentTypeId, savingsId, 
transactionId, transactionDate, amount, isReversal);
+                } else {

Review Comment:
   The transaction amount cannot be minus!!!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to