sayhaed commented on code in PR #4904:
URL: https://github.com/apache/fineract/pull/4904#discussion_r2294222242


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3847,4 +3849,22 @@ public 
List<SavingsAccountTransactionDetailsForPostingPeriod> toSavingsAccountTr
                 .map(transaction -> 
transaction.toSavingsAccountTransactionDetailsForPostingPeriod(this.currency, 
this.allowOverdraft))
                 .toList();
     }
+
+    public void accrualsForSavingsReverse(SavingsAccountTransactionDTO 
transactionDTO, final boolean backdatedTxnsAllowedTill) {

Review Comment:
   Hi @adamsaghy 
   
   The calculation process likely still loops through the account's entire 
history. However:
   
   *Accruals before the backdated transaction are untouched and skipped.
   
   *The reversed flag on accruals on or after that date acts as a signal. It 
tells the system: "This is where you need to replace the old value with a new 
calculation."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to